From: Felix Fietkau <nbd@nbd.name>
Date: Fri, 17 Oct 2025 11:15:26 +0000 (+0000)
Subject: ubusd: fix ACL check for receiving events
X-Git-Url: http://git.openwrt.org/%22https:/collectd.org///%22https:/collectd.org/?a=commitdiff_plain;h=60e04048a0e2f3e33651c19e62861b41be4c290f;p=project%2Fubus.git

ubusd: fix ACL check for receiving events

Wildcard event match must also be subject to ACL checks

Reported-by: Karsten Sperling <ksperling@apple.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---

diff --git a/ubusd_event.c b/ubusd_event.c
index 09c53dd..3036969 100644
--- a/ubusd_event.c
+++ b/ubusd_event.c
@@ -93,7 +93,7 @@ static int ubusd_alloc_event_pattern(struct ubus_client *cl, struct blob_attr *m
 		len--;
 	}
 
-	if (pattern[0] && ubusd_acl_check(cl, pattern, NULL, UBUS_ACL_LISTEN))
+	if (ubusd_acl_check(cl, pattern, NULL, UBUS_ACL_LISTEN))
 		return UBUS_STATUS_PERMISSION_DENIED;
 
 	ev = calloc(1, sizeof(*ev) + len + 1);